CodeLoom-4-Bedrock #7622
Open
CodeLoom-4-Bedrock #7622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejasgn1
added
the
Tools
github-actions
bot
removed
the
Tools
rlhagerm
requested changes
Oct 14, 2025
| # Check if python/test_tools/{service}_stubber.py exists | ||
| # If missing, create it following existing patterns | ||
| # Add to python/test_tools/stubber_factory.py | ||
| ``` |
There was a problem hiding this comment.
Add the service to the stubber factory If statement.
| #### Hello Scenario Structure | ||
| - **File naming**: `{service}_hello.py` or hello function in main module | ||
| - **Function naming**: `hello_{service}()` or `main()` | ||
| - **Documentation**: Include docstrings explaining the hello example purpose |
There was a problem hiding this comment.
Do not use wrapper functions for the hello example.
| - **Functions**: Use descriptive names with snake_case | ||
| - **Classes**: Use PascalCase for class names | ||
| - **Constants**: Use UPPER_CASE for constants | ||
| - **Type Hints**: Include type annotations where beneficial |
There was a problem hiding this comment.
Use paginators when available.
|
|
||
| 3. **Test File Structure:** | ||
| - **Unit Tests**: `test_{service}_wrapper.py` - Test wrapper class methods with mocked responses | ||
| - **Integration Tests**: `test_{service}_integration.py` - Test against real AWS services (marked with `@pytest.mark.integ`) |
There was a problem hiding this comment.
Write one integration test that runs the entire scenario.
| - **Test markers**: Use `@pytest.mark.integ` for integration tests | ||
| - **Fixtures**: Create reusable fixtures for AWS resources | ||
| - **Cleanup**: Ensure proper resource cleanup in tests | ||
| - **Mocking**: Use `boto3` stubber for unit tests when appropriate |
There was a problem hiding this comment.
Do not use MonkeyPatch mockers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes care of AI code generation using CodeLoom. CodeLoom now also works with Bedrock Knowledge Bases